Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enable BASH_EXEC checks in super-linter #3454

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

echoix
Copy link
Member

@echoix echoix commented Feb 25, 2024

I also set the executable bits on the files that didn't have them and that failed the checks. I double checked the config.guess and config.sub files by checking out the git repo with git clone https://git.savannah.gnu.org/git/config.git, both of them have the executable bit set there.

@github-actions github-actions bot added windows Microsoft Windows specific docker Docker related CI Continuous integration labels Feb 25, 2024
@neteler neteler added this to the 8.4.0 milestone Feb 25, 2024
@echoix
Copy link
Member Author

echoix commented Feb 26, 2024

I've been assigned this PR and the other one that I opened this weekend, but there's nothing that I can act upon. It's only missing to approve, and at least two of you passed through it. Was it something that you weren't directly comfortable with reviewing on the spot? What is expected for me to do with having it in my assigned PRs?

@echoix echoix merged commit 809ca1e into OSGeo:main Feb 26, 2024
26 checks passed
@echoix echoix deleted the bash-exec branch February 26, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration docker Docker related windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants